tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

leds: cht-wcove: Fix an unsigned comparison which can never be negative

Browse Source 
The return value from the call to cht_wc_leds_find_freq() is int.
However, the return value is being assigned to an unsigned
int variable 'ctrl', so making it an int.

Eliminate the following warning:
drivers/leds/leds-cht-wcove.c:236 cht_wc_leds_set_effect() warn: unsigned 'ctrl' is never less than zero.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5341
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20230531020238.102684-1-yang.lee@linux.alibaba.com
This commit is contained in:
Yang Li
2023-05-31 10:02:38 +08:00
committed by Lee Jones
parent 3f80ba4444
commit de416a9f91
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/leds/leds-cht-wcove.c
+1 -2
View File
@@ -223,8 +223,7 @@ static int cht_wc_leds_set_effect(struct led_classdev *cdev,
u8 effect) u8 effect)
{ {
struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev); struct cht_wc_led *led = container_of(cdev, struct cht_wc_led, cdev);
unsigned int ctrl; int ctrl, ret;
int ret;
mutex_lock(&led->mutex); mutex_lock(&led->mutex);