cifs: Do not convert delimiter when parsing NFS-style symlinks

BugLink: https://bugs.launchpad.net/bugs/2089884

[ Upstream commit d3a49f60917323228f8fdeee313260ef14f94df7 ]

NFS-style symlinks have target location always stored in NFS/UNIX form
where backslash means the real UNIX backslash and not the SMB path
separator.

So do not mangle slash and backslash content of NFS-style symlink during
readlink() syscall as it is already in the correct Linux form.

This fixes interoperability of NFS-style symlinks with backslashes created
by Linux NFS3 client throw Windows NFS server and retrieved by Linux SMB
client throw Windows SMB server, where both Windows servers exports the
same directory.

Fixes: d5ecebc490 ("smb3: Allow query of symlinks stored as reparse points")
Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>
Signed-off-by: Roxana Nicolescu <roxana.nicolescu@canonical.com>

This commit is contained in:

Pali Rohár

2024-09-28 23:59:46 +02:00

committed by

Mehmet Basaran

parent cca549af32

commit a316cfb374

1 changed files with 0 additions and 1 deletions

									
										fs/smb/client/reparse.c
									
		-1
	
												View File
												
				@@ -168,7 +168,6 @@ static int parse_reparse_posix(struct reparse_posix_data *buf,

											       cifs_sb->local_nls);

						if (!data->symlink_target)

							return -ENOMEM;

						convert_delimiter(data->symlink_target, '/');

						cifs_dbg(FYI, "%s: target path: %s\n",

							 __func__, data->symlink_target);

						break;