net: systemport: fix potential memory leak in bcm_sysport_xmit()

The bcm_sysport_xmit() returns NETDEV_TX_OK without freeing skb
in case of dma_map_single() fails, add dev_kfree_skb() to fix it.

Fixes: 80105befdb ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Link: https://patch.msgid.link/20241014145115.44977-1-wanghai38@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

CVE-2024-50171
(cherry picked from commit c401ed1c709948e57945485088413e1bb5e94bd1)
Signed-off-by: Massimiliano Pellizzer <massimiliano.pellizzer@canonical.com>
Acked-by: Magali Lemes <magali.lemes@canonical.com>
Acked-by: Tim Whisonant <tim.whisonant@canonical.com>
Signed-off-by: Koichiro Den <koichiro.den@canonical.com>

This commit is contained in:

Wang Hai

2025-01-16 13:22:28 +01:00

committed by

Mehmet Basaran

parent f9fd16875b

commit 95edcbb13f

1 changed files with 1 additions and 0 deletions

									
										drivers/net/ethernet/broadcom/bcmsysport.c
									
		+1
		
												View File
												
				@@ -1359,6 +1359,7 @@ static netdev_tx_t bcm_sysport_xmit(struct sk_buff *skb,

						netif_err(priv, tx_err, dev, "DMA map failed at %p (len=%d)\n",

							  skb->data, skb_len);

						ret = NETDEV_TX_OK;

						dev_kfree_skb_any(skb);

						goto out;

					}