tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

metag: hugetlbpage: Remove null pointer checks that could never happen

Browse Source 
There are inconsistent NULL checks in
hugetlb_get_unmapped_area_existing(). The last conditional block in the
loop checks vma, but vma is dereferenced after that.

Due to the checks above however (bearing in mind after_huge is either 0
or 1) vma is guaranteed not to be NULL here, so remove that part of the
check.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
[james.hogan@imgtec.com: remove brackets and expand commit message]
Signed-off-by: James Hogan <james.hogan@imgtec.com>
This commit is contained in:
Rickard Strandqvist
2014-05-30 01:11:58 +02:00
committed by James Hogan
parent 7171511eae
commit 8bc613befa
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
arch/metag/mm/hugetlbpage.c
+1 -1
View File
@@ -173,7 +173,7 @@ new_search:
mm->context.part_huge = 0; mm->context.part_huge = 0;
return addr; return addr;
} }
if (vma && (vma->vm_flags & MAP_HUGETLB)) { if (vma->vm_flags & MAP_HUGETLB) {
/* space after a huge vma in 2nd level page table? */ /* space after a huge vma in 2nd level page table? */
if (vma->vm_end & HUGEPT_MASK) { if (vma->vm_end & HUGEPT_MASK) {
after_huge = 1; after_huge = 1;