bpf: Simplify logging-related error conditions handling
Move log->level == 0 check into bpf_vlog_truncated() instead of doing it explicitly. Also remove unnecessary goto in kernel/bpf/verifier.c. Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Lorenz Bauer <lmb@isovalent.com> Link: https://lore.kernel.org/bpf/20230406234205.323208-11-andrii@kernel.org
This commit is contained in:
committed by
Daniel Borkmann
parent
cbedb42a0d
commit
8a6ca6bc55
+3
-1
@@ -169,7 +169,9 @@ static int bpf_vlog_reverse_ubuf(struct bpf_verifier_log *log, int start, int en
|
||||
|
||||
bool bpf_vlog_truncated(const struct bpf_verifier_log *log)
|
||||
{
|
||||
if (log->level & BPF_LOG_FIXED)
|
||||
if (!log->level)
|
||||
return false;
|
||||
else if (log->level & BPF_LOG_FIXED)
|
||||
return bpf_log_used(log) >= log->len_total - 1;
|
||||
else
|
||||
return log->start_pos > 0;
|
||||
|
||||
Reference in New Issue
Block a user