From 5d6a05ff1d311aa766134ed7e80821efe5cc6b2f Mon Sep 17 00:00:00 2001 From: Chuck Lever Date: Wed, 19 Mar 2025 15:21:36 +1300 Subject: [PATCH] NFSD: Reset cb_seq_status after NFS4ERR_DELAY BugLink: https://bugs.launchpad.net/bugs/2103564 I noticed that once an NFSv4.1 callback operation gets a NFS4ERR_DELAY status on CB_SEQUENCE and then the connection is lost, the callback client loops, resending it indefinitely. The switch arm in nfsd4_cb_sequence_done() that handles NFS4ERR_DELAY uses rpc_restart_call() to rearm the RPC state machine for the retransmit, but that path does not call the rpc_prepare_call callback again. Thus cb_seq_status is set to -10008 by the first NFS4ERR_DELAY result, but is never set back to 1 for the retransmits. nfsd4_cb_sequence_done() thinks it's getting nothing but a long series of CB_SEQUENCE NFS4ERR_DELAY replies. Fixes: 7ba6cad6c88f ("nfsd: New helper nfsd4_cb_sequence_done() for processing more cb errors") Reviewed-by: Jeff Layton Reviewed-by: Benjamin Coddington Signed-off-by: Chuck Lever (cherry picked from commit 961b4b5e86bf56a2e4b567f81682defa5cba957e) Signed-off-by: Matthew Ruffell Acked-by: Andrei Gherzan Acked-by: Kuba Pawlak Signed-off-by: Mehmet Basaran --- fs/nfsd/nfs4callback.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c index fef882b33740..83176d770521 100644 --- a/fs/nfsd/nfs4callback.c +++ b/fs/nfsd/nfs4callback.c @@ -1273,6 +1273,7 @@ static bool nfsd4_cb_sequence_done(struct rpc_task *task, struct nfsd4_callback ret = false; break; case -NFS4ERR_DELAY: + cb->cb_seq_status = 1; if (!rpc_restart_call(task)) goto out;