tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qlge: fix duplicated code for different branches

Browse Source 
Refactor code in order to avoid identical code for different branches.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Gustavo A. R. Silva
2017-08-12 20:58:40 -05:00
committed by David S. Miller
parent b5e7dc4742
commit 4db93fb8ac
1 changed files with 14 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/ethernet/qlogic/qlge/qlge_dbg.c
+14 -33
View File
@@ -144,42 +144,23 @@ static int ql_get_serdes_regs(struct ql_adapter *qdev,
xaui_direct_valid = xaui_indirect_valid = 1; xaui_direct_valid = xaui_indirect_valid = 1;
/* The XAUI needs to be read out per port */ /* The XAUI needs to be read out per port */
if (qdev->func & 1) { status = ql_read_other_func_serdes_reg(qdev,
/* We are NIC 2 */ XG_SERDES_XAUI_HSS_PCS_START, &temp);
status = ql_read_other_func_serdes_reg(qdev, if (status)
XG_SERDES_XAUI_HSS_PCS_START, &temp); temp = XG_SERDES_ADDR_XAUI_PWR_DOWN;
if (status)
temp = XG_SERDES_ADDR_XAUI_PWR_DOWN;
if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) ==
XG_SERDES_ADDR_XAUI_PWR_DOWN)
xaui_indirect_valid = 0;
status = ql_read_serdes_reg(qdev, if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) ==
XG_SERDES_XAUI_HSS_PCS_START, &temp); XG_SERDES_ADDR_XAUI_PWR_DOWN)
if (status) xaui_indirect_valid = 0;
temp = XG_SERDES_ADDR_XAUI_PWR_DOWN;
if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) == status = ql_read_serdes_reg(qdev, XG_SERDES_XAUI_HSS_PCS_START, &temp);
XG_SERDES_ADDR_XAUI_PWR_DOWN)
xaui_direct_valid = 0;
} else {
/* We are NIC 1 */
status = ql_read_other_func_serdes_reg(qdev,
XG_SERDES_XAUI_HSS_PCS_START, &temp);
if (status)
temp = XG_SERDES_ADDR_XAUI_PWR_DOWN;
if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) ==
XG_SERDES_ADDR_XAUI_PWR_DOWN)
xaui_indirect_valid = 0;
status = ql_read_serdes_reg(qdev, if (status)
XG_SERDES_XAUI_HSS_PCS_START, &temp); temp = XG_SERDES_ADDR_XAUI_PWR_DOWN;
if (status)
temp = XG_SERDES_ADDR_XAUI_PWR_DOWN; if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) ==
if ((temp & XG_SERDES_ADDR_XAUI_PWR_DOWN) == XG_SERDES_ADDR_XAUI_PWR_DOWN)
XG_SERDES_ADDR_XAUI_PWR_DOWN) xaui_direct_valid = 0;
xaui_direct_valid = 0;
}
/* /*
* XFI register is shared so only need to read one * XFI register is shared so only need to read one