From 49618adbd513ef54fbaa9ca93ab1c3cd00d60d47 Mon Sep 17 00:00:00 2001 From: Ryusuke Konishi Date: Tue, 25 Feb 2025 22:59:22 +0900 Subject: [PATCH] nilfs2: fix kernel bug due to missing clearing of checked flag BugLink: https://bugs.launchpad.net/bugs/2099996 commit 41e192ad2779cae0102879612dfe46726e4396aa upstream. Syzbot reported that in directory operations after nilfs2 detects filesystem corruption and degrades to read-only, __block_write_begin_int(), which is called to prepare block writes, may fail the BUG_ON check for accesses exceeding the folio/page size, triggering a kernel bug. This was found to be because the "checked" flag of a page/folio was not cleared when it was discarded by nilfs2's own routine, which causes the sanity check of directory entries to be skipped when the directory page/folio is reloaded. So, fix that. This was necessary when the use of nilfs2's own page discard routine was applied to more than just metadata files. Link: https://lkml.kernel.org/r/20241017193359.5051-1-konishi.ryusuke@gmail.com Fixes: 8c26c4e2694a ("nilfs2: fix issue with flush kernel thread after remount in RO mode because of driver's internal error or metadata corruption") Signed-off-by: Ryusuke Konishi Reported-by: syzbot+d6ca2daf692c7a82f959@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=d6ca2daf692c7a82f959 Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman CVE-2024-50230 Signed-off-by: Koichiro Den Signed-off-by: Stefan Bader --- fs/nilfs2/page.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/nilfs2/page.c b/fs/nilfs2/page.c index d618ee068bc4..235c4b3f8c42 100644 --- a/fs/nilfs2/page.c +++ b/fs/nilfs2/page.c @@ -409,6 +409,7 @@ void nilfs_clear_folio_dirty(struct folio *folio, bool silent) folio_clear_uptodate(folio); folio_clear_mappedtodisk(folio); + folio_clear_checked(folio); head = folio_buffers(folio); if (head) {