From 38150ed1e54ee57e1992f2d616c35000e66e5228 Mon Sep 17 00:00:00 2001 From: Saravana Kannan Date: Wed, 23 Oct 2024 23:13:43 -0700 Subject: [PATCH] phy: tegra: xusb: Set fwnode for xusb port devices MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fwnode needs to be set for a device for fw_devlink to be able to track/enforce its dependencies correctly. Without this, you'll see error messages like this when the supplier has probed and tries to make sure all its fwnode consumers are linked to it using device links: tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180) with 1-0008 http://nvbugs/4429863 http://nvbugs/4781717 Reported-by: Jon Hunter Closes: https://lore.kernel.org/all/20240910130019.35081-1-jonathanh@nvidia.com/ Tested-by: Jon Hunter Suggested-by: Nícolas F. R. A. Prado Signed-off-by: Saravana Kannan Acked-by: Thierry Reding Link: https://lore.kernel.org/r/20241024061347.1771063-3-saravanak@google.com Signed-off-by: Greg Kroah-Hartman (cherry picked from commit 74ffe43bad3af3e2a786ca017c205555ba87ebad) Signed-off-by: Jon Hunter Reviewed-by: Brad Griffis Signed-off-by: Vishwaroop A Acked-by: Noah Wager Acked-by: Jacob Martin Signed-off-by: Noah Wager --- drivers/phy/tegra/xusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index f426b43964d7..72b47585dc37 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -549,7 +549,7 @@ static int tegra_xusb_port_init(struct tegra_xusb_port *port, device_initialize(&port->dev); port->dev.type = &tegra_xusb_port_type; - port->dev.of_node = of_node_get(np); + device_set_node(&port->dev, of_fwnode_handle(of_node_get(np))); port->dev.parent = padctl->dev; err = dev_set_name(&port->dev, "%s-%u", name, index);