btrfs: tree-checker: fix the wrong output of data backref objectid

BugLink: https://bugs.launchpad.net/bugs/2089340

commit b0b595e61d97de61c15b379b754b2caa90e83e5c upstream.

[BUG]
There are some reports about invalid data backref objectids, the report
looks like this:

  BTRFS critical (device sda): corrupt leaf: block=333654787489792 slot=110 extent bytenr=333413935558656 len=65536 invalid data ref objectid value 2543

The data ref objectid is the inode number inside the subvolume.

But in above case, the value is completely sane, not really showing the
problem.

[CAUSE]
The root cause of the problem is the deprecated feature, inode cache.

This feature results a special inode number, -12ULL, and it's no longer
recognized by tree-checker, triggering the error.

The direct problem here is the output of data ref objectid. The value
shown is in fact the dref_root (subvolume id), not the dref_objectid
(inode number).

[FIX]
Fix the output to use dref_objectid instead.

Reported-by: Neil Parton <njparton@gmail.com>
Reported-by: Archange <archange@archlinux.org>
Link: https://lore.kernel.org/linux-btrfs/CAAYHqBbrrgmh6UmW3ANbysJX9qG9Pbg3ZwnKsV=5mOpv_qix_Q@mail.gmail.com/
Link: https://lore.kernel.org/linux-btrfs/9541deea-9056-406e-be16-a996b549614d@archlinux.org/
Fixes: f333a3c7e832 ("btrfs: tree-checker: validate dref root and objectid")
CC: stable@vger.kernel.org # 6.11
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Portia Stephens <portia.stephens@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

This commit is contained in:

Qu Wenruo

2024-09-11 07:06:45 +09:30

committed by

Mehmet Basaran

parent ccce5656f4

commit 18f01e13c5

1 changed files with 1 additions and 1 deletions

									
										fs/btrfs/tree-checker.c
									
		+1
		-1
	
												View File
												
				@@ -1495,7 +1495,7 @@ static int check_extent_item(struct extent_buffer *leaf,

								     dref_objectid > BTRFS_LAST_FREE_OBJECTID)) {

								extent_err(leaf, slot,

									   "invalid data ref objectid value %llu",

									   dref_root);

									   dref_objectid);

								return -EUCLEAN;

							}

							if (unlikely(!IS_ALIGNED(dref_offset,