tmakin/tegra-linux-noble
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

irqchip/irq-alpine-msi: Release the correct domain on error

Browse Source 
The "msi_domain" variable is NULL here so it leads to a NULL dereference.  It
looks like we actually intended to free "middle_domain".

Fixes: e6b78f2c3e ('irqchip: Add the Alpine MSIX interrupt controller')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: kernel-janitors@vger.kernel.org
Cc: Tsahee Zidenberg <tsahee@annapurnalabs.com>
Link: http://lkml.kernel.org/r/20160311081442.GE31887@mwanda
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Dan Carpenter
2016-03-11 11:14:43 +03:00
committed by Thomas Gleixner
parent edf8fcdc6b
commit 143d36a33b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/irqchip/irq-alpine-msi.c
View File

@@ -220,7 +220,7 @@ static int alpine_msix_init_domains(struct alpine_msix_data *priv,
middle_domain); middle_domain);
if (!msi_domain) { if (!msi_domain) {
pr_err("Failed to create MSI domain\n"); pr_err("Failed to create MSI domain\n");
irq_domain_remove(msi_domain); irq_domain_remove(middle_domain);
return -ENOMEM; return -ENOMEM;
} }