Oleg Nesterov ee77f07592
signal: Turn SIGNAL_STOP_DEQUEUED into GROUP_STOP_DEQUEUED ...
This patch moves SIGNAL_STOP_DEQUEUED from signal_struct->flags to
task_struct->group_stop, and thus makes it per-thread.
Like SIGNAL_STOP_DEQUEUED, GROUP_STOP_DEQUEUED can be false-positive
after return from get_signal_to_deliver(), this is fine. The only
purpose of this bit is: we can drop ->siglock after __dequeue_signal()
returns the sig_kernel_stop() signal and before we call
do_signal_stop(), in this case we must not miss SIGCONT if it comes in
between.
But, unlike SIGNAL_STOP_DEQUEUED, GROUP_STOP_DEQUEUED can not be
false-positive in do_signal_stop() if multiple threads dequeue the
sig_kernel_stop() signal at the same time.
Consider two threads T1 and T2, SIGTTIN has a hanlder.
- T1 dequeues SIGTSTP and sets SIGNAL_STOP_DEQUEUED, then
it drops ->siglock
- SIGCONT comes and clears SIGNAL_STOP_DEQUEUED, SIGTSTP
should be cancelled.
- T2 dequeues SIGTTIN and sets SIGNAL_STOP_DEQUEUED again.
Since we have a handler we should not stop, T2 returns
to usermode to run the handler.
- T1 continues, calls do_signal_stop() and wrongly starts
the group stop because SIGNAL_STOP_DEQUEUED was restored
in between.
With or without this change:
- we need to do something with ptrace_signal() which can
return SIGSTOP, but this needs another discussion
- SIGSTOP can be lost if it races with the mt exec, will
be fixed later.
Signed-off-by: Oleg Nesterov <oleg@redhat.com >
Signed-off-by: Tejun Heo <tj@kernel.org >
2011-04-04 02:11:05 +02:00
2011-03-17 11:04:51 +00:00
2011-01-30 01:14:14 -08:00
2011-03-22 11:33:55 -07:00
2011-03-22 10:05:27 -07:00
2011-03-18 23:38:50 -07:00
2011-03-19 22:27:06 -07:00
2011-03-17 15:35:22 -04:00
2011-03-18 10:50:27 -07:00
2011-03-20 15:33:26 +01:00
2011-01-20 17:50:17 +01:00
2011-01-20 17:50:17 +01:00
2011-01-20 17:50:17 +01:00
2011-01-13 21:04:07 -05:00
2011-03-16 15:11:04 -07:00
2011-01-14 18:11:59 +03:00
2011-03-19 22:27:06 -07:00
2011-02-18 16:54:54 -05:00
2011-03-17 12:38:59 -04:00
2011-03-16 15:11:04 -07:00
2011-01-20 18:30:17 -08:00
2011-01-20 18:30:17 -08:00
2011-03-15 02:42:32 -04:00
2011-01-31 14:03:00 -08:00
2011-01-19 23:51:37 +01:00
2011-01-15 20:07:45 -05:00
2011-03-22 17:43:59 -07:00
2011-03-02 08:48:05 -05:00
2011-03-03 10:53:20 -05:00
2011-02-16 13:30:48 +01:00
2011-02-16 13:30:48 +01:00
2011-03-22 17:44:00 -07:00
2011-03-22 17:44:10 -07:00
2011-03-22 17:44:10 -07:00
2011-03-22 17:44:10 -07:00
2011-02-23 13:22:26 -08:00
2011-01-26 10:50:06 +10:00
2011-01-24 14:51:56 -08:00
2011-03-16 17:54:33 -04:00
2011-03-22 17:44:15 -07:00
2011-03-21 12:13:10 -04:00
2011-03-14 17:02:43 -07:00
2011-01-20 17:01:09 -08:00
2011-03-08 16:10:38 +01:00
2011-03-16 17:28:10 -07:00
2011-01-17 10:54:41 -08:00
2011-02-25 12:00:34 -08:00
2011-03-07 01:12:28 +05:30
2011-02-03 15:39:16 -08:00
2011-03-14 08:40:51 -07:00
2011-03-22 17:44:11 -07:00
2011-01-13 21:49:56 -08:00
2011-03-18 15:13:11 -07:00
2011-03-15 02:21:37 -04:00
2011-03-08 11:38:10 +11:00
2011-03-17 09:19:20 +08:00
2011-03-14 19:12:20 -04:00
2011-03-15 02:21:45 -04:00
2011-03-21 10:05:22 -07:00
2011-02-03 15:39:17 -08:00
2011-02-16 17:48:59 +01:00
2011-03-22 17:44:10 -07:00
2011-03-10 10:31:48 -05:00
2011-02-11 16:23:33 -05:00
2011-03-22 17:44:05 -07:00
2011-01-14 08:06:39 -08:00
2011-03-05 10:56:00 +01:00
2011-02-03 16:37:28 +01:00
2011-03-17 14:31:46 +01:00
2011-02-11 15:05:49 +01:00
2011-03-10 19:15:58 +01:00
2011-02-15 15:21:11 -08:00
2011-02-17 09:52:03 -08:00
2011-02-23 00:53:26 +00:00
2011-03-20 14:50:53 +01:00
2011-03-12 15:08:54 -08:00
2011-03-09 16:10:56 -05:00
2011-01-19 23:31:09 -08:00
2011-03-18 15:14:45 -07:00
2011-02-27 16:11:51 -08:00
2011-03-10 16:37:26 -08:00
2011-02-10 07:51:44 -05:00
2011-02-18 12:42:28 -08:00
2011-01-31 21:17:41 -08:00
2011-01-31 21:16:59 -08:00
2011-03-15 19:23:40 -07:00
2011-03-12 11:12:58 +01:00
2011-03-11 14:15:35 +01:00
2011-01-26 12:33:20 +01:00
2011-03-22 16:17:32 -07:00
2011-01-31 14:03:00 -08:00
2011-02-17 11:12:40 -08:00
2011-03-22 17:44:14 -07:00
2011-03-08 11:17:18 +11:00
2011-03-08 11:17:18 +11:00
2011-03-08 11:17:22 +11:00
2011-01-13 17:32:47 -08:00
2011-02-13 16:54:24 -08:00
2011-01-24 14:45:11 +10:30
2011-02-18 08:02:10 -08:00
2011-03-22 17:44:01 -07:00
2011-03-17 13:08:30 -03:00
2011-03-22 17:43:59 -07:00
2011-03-22 17:43:59 -07:00
2011-03-14 02:52:41 -04:00
2011-01-14 13:12:45 +00:00
2011-02-18 11:32:28 -08:00
2011-01-21 13:38:57 -08:00
2011-03-18 22:33:38 -07:00
2011-03-22 17:44:03 -07:00
2011-01-15 13:28:17 +02:00
2011-02-03 16:08:57 -08:00
2011-02-14 17:38:30 -08:00
2011-01-13 17:32:46 -08:00
2011-03-22 17:44:03 -07:00
2011-03-22 17:44:04 -07:00
2011-01-13 17:32:46 -08:00
2011-02-15 10:24:31 +01:00
2011-02-21 15:21:53 -08:00
2011-01-24 14:32:52 +10:30
2011-01-16 13:47:07 -05:00
2011-02-03 18:05:29 -08:00
2011-01-30 01:14:38 -08:00
2011-03-02 13:43:15 -08:00
2011-03-18 09:04:20 -04:00
2011-02-22 10:19:31 -08:00
2011-03-16 12:53:54 -07:00
2011-01-18 16:08:30 +01:00
2011-03-03 13:32:07 -08:00
2011-01-14 13:17:26 -08:00
2011-03-11 15:39:27 -05:00
2011-03-11 15:38:40 -05:00
2011-03-11 15:39:26 -05:00
2011-03-11 15:38:44 -05:00
2011-03-11 15:38:44 -05:00
2011-03-14 18:25:53 -04:00
2011-01-25 15:24:47 -05:00
2011-03-10 17:29:40 +09:00
2011-03-01 13:48:21 -05:00
2011-02-03 16:08:57 -08:00
2011-02-28 01:36:38 -07:00
2011-01-15 22:01:58 -07:00
2011-02-04 11:46:50 -07:00
2011-03-01 09:38:26 -07:00
2011-03-16 17:28:10 -07:00
2011-02-15 11:10:20 +01:00
2011-01-14 07:52:02 -08:00
2011-03-22 17:44:03 -07:00
2011-03-22 17:44:02 -07:00
2011-03-14 02:58:03 -04:00
2011-01-16 13:47:07 -05:00
2011-03-18 10:56:44 -07:00
2011-01-16 11:56:26 -08:00
2011-03-18 10:56:44 -07:00
2011-02-28 11:20:03 +01:00
2011-03-16 14:04:14 +01:00
2011-03-09 11:59:33 -08:00
2011-02-24 22:11:56 -08:00
2011-02-18 08:15:51 -08:00
2011-03-11 15:13:26 -05:00
2011-03-15 00:43:14 +01:00
2011-03-15 00:43:14 +01:00
2011-03-15 00:43:16 +01:00
2011-01-25 15:24:47 -05:00
2011-02-02 15:28:20 +01:00
2011-02-02 15:28:20 +01:00
2011-03-04 09:23:30 -08:00
2011-03-22 17:44:00 -07:00
2011-01-13 17:32:48 -08:00
2011-01-14 02:36:43 +00:00
2011-02-01 11:12:29 -05:00
2011-02-02 16:03:19 -08:00
2011-03-09 13:52:27 -05:00
2011-02-25 15:07:37 -08:00
2011-03-22 17:44:03 -07:00
2011-03-09 11:23:37 -08:00
2011-01-27 12:30:38 +01:00
2011-01-27 12:30:39 +01:00
2011-01-27 12:30:40 +01:00
2011-04-04 02:11:05 +02:00
2011-03-16 16:29:25 -07:00
2011-01-19 15:37:31 +09:00
2011-03-22 17:44:15 -07:00
2011-03-16 12:53:54 -07:00
2011-01-23 21:00:05 +02:00
2011-03-22 20:48:04 +02:00
2011-03-22 17:44:11 -07:00
2011-03-09 14:08:09 -08:00
2011-01-27 12:30:38 +01:00
2011-03-15 00:43:16 +01:00
2011-03-22 17:44:04 -07:00
2011-03-21 00:40:29 -04:00
2011-03-15 00:43:46 +01:00
2011-03-09 16:43:24 -08:00
2011-01-24 09:33:36 -08:00
2011-02-28 18:00:31 -08:00
2011-02-02 15:28:13 +01:00
2011-02-04 12:41:21 -08:00
2011-02-21 12:53:08 -08:00
2011-02-02 15:28:18 +01:00
2011-03-13 16:35:18 -04:00
2011-02-23 18:05:11 -05:00
2011-03-23 10:37:00 +01:00
2011-02-03 09:28:46 -05:00
2011-02-17 11:59:56 -08:00
2011-03-22 16:17:32 -07:00
2011-03-22 17:44:09 -07:00
2011-02-04 11:48:55 -08:00
2011-01-24 14:45:11 +10:30
2011-02-09 08:19:55 +10:30
2011-03-22 17:44:05 -07:00
2011-02-17 11:13:19 -08:00
2011-02-21 10:07:23 +01:00
2011-01-17 08:05:27 -08:00
2011-03-13 20:22:28 -07:00
2011-03-22 17:44:17 -07:00
ee77f07592