Paul Gortmaker 169f1a2a87
jbd2: use a single printk for jbd_debug() ...
Since the jbd_debug() is implemented with two separate printk()
calls, it can lead to corrupted and misleading debug output like
the following (see lines marked with "*"):
[ 290.339362] (fs/jbd2/journal.c, 203): kjournald2: kjournald2 wakes
[ 290.339365] (fs/jbd2/journal.c, 155): kjournald2: commit_sequence=42103, commit_request=42104
[ 290.339369] (fs/jbd2/journal.c, 158): kjournald2: OK, requests differ
[* 290.339376] (fs/jbd2/journal.c, 648): jbd2_log_wait_commit:
[* 290.339379] (fs/jbd2/commit.c, 370): jbd2_journal_commit_transaction: JBD2: want 42104, j_commit_sequence=42103
[* 290.339382] JBD2: starting commit of transaction 42104
[ 290.339410] (fs/jbd2/revoke.c, 566): jbd2_journal_write_revoke_records: Wrote 0 revoke records
[ 290.376555] (fs/jbd2/commit.c, 1088): jbd2_journal_commit_transaction: JBD2: commit 42104 complete, head 42079
i.e. the debug output from log_wait_commit and journal_commit_transaction
have become interleaved. The output should have been:
(fs/jbd2/journal.c, 648): jbd2_log_wait_commit: JBD2: want 42104, j_commit_sequence=42103
(fs/jbd2/commit.c, 370): jbd2_journal_commit_transaction: JBD2: starting commit of transaction 42104
It is expected that this is not easy to replicate -- I was only able
to cause it on preempt-rt kernels, and even then only under heavy
I/O load.
Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com >
Suggested-by: "Theodore Ts'o" <tytso@mit.edu >
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com >
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu >
2013-06-12 23:04:04 -04:00
2013-04-12 14:27:55 -04:00
2013-05-02 11:58:41 -05:00
2013-05-04 12:31:18 -07:00
2013-04-08 16:36:23 +02:00
2013-04-30 09:36:50 -07:00
2013-05-05 17:36:20 -07:00
2013-04-11 03:39:00 -07:00
2013-05-05 17:36:20 -07:00
2013-05-11 16:12:44 -07:00
2013-05-06 15:41:42 -07:00
2013-05-09 10:15:46 -07:00
2013-04-29 20:09:03 +02:00
2013-05-14 13:40:45 +02:00
2013-05-09 13:05:24 -07:00
2013-04-16 17:38:10 -07:00
2013-04-28 02:13:43 +01:00
2013-05-13 18:27:18 +04:00
2013-04-23 14:09:39 -04:00
2013-04-29 16:23:34 -04:00
2013-05-08 13:13:29 -07:00
2013-04-15 22:04:10 +05:30
2013-04-12 00:31:18 +02:00
2013-04-30 15:21:02 -07:00
2013-05-07 19:46:02 -07:00
2013-05-07 22:27:15 -04:00
2013-04-10 23:41:16 +02:00
2013-04-29 15:40:23 -04:00
2013-05-08 10:13:35 -07:00
2013-05-08 10:13:35 -07:00
2013-04-18 09:00:26 -07:00
2013-04-29 15:54:39 -07:00
2013-05-21 23:17:23 -04:00
2013-04-14 10:06:31 -07:00
2013-05-07 20:16:25 -07:00
2013-04-30 17:04:01 -07:00
2013-04-12 11:22:35 -07:00
2013-04-10 16:33:53 -07:00
2013-04-30 15:21:02 -07:00
2013-05-02 09:03:55 -07:00
2013-05-09 13:46:38 -04:00
2013-04-29 18:28:13 -07:00
2013-04-08 17:28:34 +02:00
2013-04-29 18:28:13 -07:00
2013-04-27 09:25:59 +08:00
2013-04-08 17:39:23 +02:00
2013-05-11 15:23:17 -07:00
2013-05-01 17:51:54 -07:00
2013-04-29 18:28:19 -07:00
2013-04-29 15:54:27 -07:00
2013-05-10 14:37:17 +01:00
2013-05-01 13:20:04 -07:00
2013-05-01 16:36:22 +05:30
2013-05-02 21:52:26 +05:30
2013-04-30 17:04:02 -07:00
2013-04-30 16:03:10 +01:00
2013-05-07 18:38:27 -07:00
2013-04-29 18:28:40 -07:00
2013-05-01 17:31:42 -04:00
2013-05-01 16:28:48 -04:00
2013-04-30 17:04:00 -07:00
2013-05-21 23:17:23 -04:00
2013-04-29 18:28:41 -07:00
2013-05-09 20:14:25 -04:00
2013-05-09 20:10:22 -04:00
2013-04-29 18:28:13 -07:00
2013-04-11 10:00:05 +08:00
2013-04-16 18:47:14 +09:00
2013-04-30 10:09:06 +02:00
2013-05-06 13:07:33 +02:00
2013-04-29 15:54:38 -07:00
2013-05-07 18:38:27 -07:00
2013-04-29 15:54:26 -07:00
2013-04-29 13:54:36 -04:00
2013-05-08 11:51:05 -07:00
2013-04-16 15:29:45 +02:00
2013-04-21 15:56:59 -04:00
2013-05-02 12:10:19 +02:00
2013-04-29 15:54:37 -07:00
2013-05-01 08:12:58 -07:00
2013-06-12 23:04:04 -04:00
2013-06-12 23:02:35 -04:00
2013-06-12 23:02:35 -04:00
2013-05-13 09:45:01 -04:00
2013-04-29 15:42:02 -04:00
2013-05-05 10:58:06 -07:00
2013-04-17 12:35:33 -07:00
2013-04-30 17:04:06 -07:00
2013-04-08 17:28:34 +02:00
2013-05-16 07:55:07 -07:00
2013-04-30 17:04:02 -07:00
2013-04-19 16:39:13 -04:00
2013-05-05 14:47:31 -07:00
2013-04-07 13:05:35 +03:00
2013-05-05 10:58:06 -07:00
2013-04-30 19:13:05 +02:00
2013-04-15 14:06:39 +00:00
2013-04-08 16:57:15 -07:00
2013-04-29 15:54:37 -07:00
2013-04-30 17:04:00 -07:00
2013-05-21 23:17:23 -04:00
2013-04-30 09:36:50 -07:00
2013-04-23 09:50:30 -06:00
2013-04-19 09:33:36 +02:00
2013-04-29 18:28:44 -07:00
2013-05-02 07:34:58 -07:00
2013-05-06 11:06:51 -04:00
2013-04-05 21:08:11 +02:00
2013-04-19 14:57:58 -04:00
2013-05-01 15:00:24 -04:00
2013-04-14 12:59:28 -04:00
2013-04-08 22:12:33 -04:00
2013-05-06 17:24:22 -04:00
2013-04-29 15:54:36 -07:00
2013-05-04 14:47:26 -04:00
2013-05-08 09:55:05 -04:00
2013-05-02 21:50:38 +05:30
2013-04-09 14:58:32 -05:00
2013-05-07 11:22:14 -07:00
2013-04-29 15:54:28 -07:00
2013-04-19 22:25:51 +02:00
2013-04-17 10:21:17 -06:00
2013-05-02 07:32:24 -07:00
2013-04-12 16:52:01 -06:00
2013-04-17 10:21:17 -06:00
2013-04-17 10:21:17 -06:00
2013-05-01 14:08:52 -07:00
2013-04-17 10:21:17 -06:00
2013-05-02 17:54:19 +02:00
2013-05-07 20:16:25 -07:00
2013-04-09 14:13:02 -04:00
2013-05-05 13:23:27 -07:00
2013-04-16 18:51:16 -07:00
2013-04-09 10:48:33 -07:00
2013-04-30 17:04:02 -07:00
2013-05-01 17:29:47 -04:00
2013-05-01 17:29:39 -04:00
2013-04-09 14:13:35 -04:00
2013-04-29 15:54:28 -07:00
2013-05-07 18:38:27 -07:00
2013-05-02 17:54:19 +02:00
2013-04-30 17:04:09 -07:00
2013-04-07 14:06:17 +03:00
2013-04-29 19:14:20 -07:00
2013-04-12 10:26:23 +02:00
2013-04-12 10:26:23 +02:00
2013-04-29 18:28:22 -07:00
2013-05-02 19:40:34 -07:00
2013-05-11 14:29:11 -07:00
2013-04-09 13:19:39 -04:00
2013-04-30 16:27:51 -07:00
2013-04-09 14:13:29 -04:00
2013-04-11 13:14:36 -07:00
2013-05-01 17:51:54 -07:00
2013-04-19 14:57:57 -04:00
2013-05-06 09:24:16 +03:00
2013-04-30 17:04:03 -07:00
2013-04-29 13:21:30 -04:00
2013-04-09 10:48:33 -07:00
2013-04-30 17:04:03 -07:00
2013-04-30 15:50:12 +05:30
2013-04-29 15:54:38 -07:00
2013-04-17 12:35:32 -07:00
2013-05-09 09:40:49 -07:00
2013-04-22 20:29:07 +02:00
2013-05-14 20:54:06 +02:00
2013-04-04 13:18:31 -07:00
2013-04-25 21:01:45 +08:00
2013-04-04 13:18:14 -07:00
2013-05-11 14:29:11 -07:00
2013-04-19 00:40:07 +02:00
2013-04-15 21:23:03 +01:00
2013-04-13 15:31:58 +02:00
2013-05-02 14:14:04 -07:00
2013-04-29 15:54:34 -07:00
2013-04-29 15:54:38 -07:00
2013-04-29 15:54:37 -07:00
2013-05-07 18:38:28 -07:00
2013-04-30 17:04:02 -07:00
2013-05-07 20:16:25 -07:00
169f1a2a87