Konrad Rzeszutek Wilk f84adf4921
xen-blkfront: drop the use of llist_for_each_entry_safe ...
Replace llist_for_each_entry_safe with a while loop.
llist_for_each_entry_safe can trigger a bug in GCC 4.1, so it's best
to remove it and use a while loop and do the deletion manually.
Specifically this bug can be triggered by hot-unplugging a disk, either
by doing xm block-detach or by save/restore cycle.
BUG: unable to handle kernel paging request at fffffffffffffff0
IP: [<ffffffffa0047223>] blkif_free+0x63/0x130 [xen_blkfront]
The crash call trace is:
...
bad_area_nosemaphore+0x13/0x20
do_page_fault+0x25e/0x4b0
page_fault+0x25/0x30
? blkif_free+0x63/0x130 [xen_blkfront]
blkfront_resume+0x46/0xa0 [xen_blkfront]
xenbus_dev_resume+0x6c/0x140
pm_op+0x192/0x1b0
device_resume+0x82/0x1e0
dpm_resume+0xc9/0x1a0
dpm_resume_end+0x15/0x30
do_suspend+0x117/0x1e0
When drilling down to the assembler code, on newer GCC it does
.L29:
cmpq $-16, %r12 #, persistent_gnt check
je .L30 #, out of the loop
.L25:
... code in the loop
testq %r13, %r13 # n
je .L29 #, back to the top of the loop
cmpq $-16, %r12 #, persistent_gnt check
movq 16(%r12), %r13 # <variable>.node.next, n
jne .L25 #, back to the top of the loop
.L30:
While on GCC 4.1, it is:
L78:
... code in the loop
testq %r13, %r13 # n
je .L78 #, back to the top of the loop
movq 16(%rbx), %r13 # <variable>.node.next, n
jmp .L78 #, back to the top of the loop
Which basically means that the exit loop condition instead of
being:
&(pos)->member != NULL;
is:
;
which makes the loop unbound.
Since xen-blkfront is the only user of the llist_for_each_entry_safe
macro remove it from llist.h.
Orabug: 16263164
CC: stable@vger.kernel.org
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com >
2013-02-19 15:17:08 -05:00
2012-12-03 11:15:35 +00:00
2013-01-03 15:57:15 -08:00
2012-10-17 12:31:15 +01:00
2012-10-17 12:31:15 +01:00
2012-12-20 14:00:13 -08:00
2012-12-14 14:54:26 -08:00
2012-10-02 18:01:25 +01:00
2012-10-15 10:03:12 +08:00
2013-01-02 17:36:10 -08:00
2012-12-18 16:51:10 -08:00
2012-11-20 21:28:51 +00:00
2012-12-18 12:46:37 -08:00
2012-12-14 14:42:53 -08:00
2012-10-17 12:31:15 +01:00
2013-01-27 01:35:32 +01:00
2012-12-19 11:47:22 -08:00
2012-12-11 11:19:09 -08:00
2012-12-03 16:36:52 +02:00
2012-10-17 12:31:15 +01:00
2012-10-17 12:31:15 +01:00
2012-10-17 12:31:15 +01:00
2012-10-17 12:31:15 +01:00
2012-11-30 12:01:30 -05:00
2012-10-17 12:31:15 +01:00
2012-11-21 08:55:26 +01:00
2013-01-08 09:44:06 +01:00
2012-12-13 19:26:04 -08:00
2013-01-02 17:36:10 -08:00
2012-12-10 12:43:22 +09:00
2012-12-07 17:02:47 +00:00
2012-12-14 14:27:45 -08:00
2012-12-20 14:04:11 -08:00
2012-10-17 12:31:15 +01:00
2013-02-09 07:55:24 +11:00
2012-10-17 12:31:15 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-30 12:37:36 +01:00
2012-12-14 10:03:23 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-08 13:50:19 +10:30
2012-10-08 13:50:20 +10:30
2012-12-14 13:06:41 +10:30
2013-01-03 15:57:16 -08:00
2013-01-14 13:29:15 -05:00
2012-10-13 10:46:48 +01:00
2012-12-10 15:49:57 -05:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-02 00:05:12 +00:00
2012-11-20 18:18:52 +09:00
2012-10-09 16:22:46 +09:00
2013-01-11 14:54:56 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-17 11:29:09 -08:00
2012-12-17 17:15:16 -08:00
2012-12-11 17:22:26 -08:00
2012-12-06 14:58:56 -05:00
2012-12-20 20:00:43 -08:00
2012-12-19 07:18:35 -08:00
2012-10-13 10:46:48 +01:00
2012-12-12 17:38:35 -08:00
2012-12-06 14:33:02 +01:00
2012-10-13 10:46:48 +01:00
2012-11-26 17:41:24 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-20 06:44:58 -08:00
2012-12-11 11:25:08 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2013-01-11 14:54:56 -08:00
2012-12-20 18:05:28 -08:00
2012-12-19 07:55:08 -08:00
2012-12-06 01:22:31 +00:00
2012-12-19 07:55:08 -08:00
2012-10-13 10:46:48 +01:00
2012-10-12 06:37:36 -05:00
2012-11-30 11:40:07 -08:00
2012-11-29 00:01:25 -05:00
2012-11-22 15:59:52 +08:00
2013-01-11 14:54:54 -08:00
2012-11-15 00:33:07 +01:00
2013-01-15 14:18:04 +01:00
2012-12-12 17:38:32 -08:00
2012-10-13 10:46:48 +01:00
2013-01-09 08:26:53 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-20 13:57:36 -05:00
2012-10-13 10:46:48 +01:00
2012-11-26 19:17:44 +09:00
2012-12-21 20:23:41 +00:00
2012-12-14 09:59:59 -08:00
2012-10-22 16:50:13 -07:00
2012-10-13 10:46:48 +01:00
2012-11-19 14:32:13 +01:00
2012-11-29 03:30:34 -08:00
2012-12-20 12:05:06 +05:30
2012-12-11 09:28:09 +01:00
2012-10-24 17:06:43 +02:00
2012-11-09 14:05:45 +01:00
2012-11-08 16:58:31 +01:00
2012-11-09 14:11:43 +01:00
2012-09-27 15:35:23 +05:30
2012-10-24 15:57:14 -07:00
2012-09-30 18:02:20 -07:00
2012-11-28 11:54:40 +01:00
2012-10-13 10:46:48 +01:00
2012-09-29 12:21:03 -07:00
2013-01-30 11:51:59 -08:00
2012-10-16 18:49:15 -07:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-02 21:34:05 -04:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-20 14:04:11 -08:00
2012-11-22 13:43:27 +09:00
2012-12-11 13:43:45 +09:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-28 21:49:02 -05:00
2012-09-26 22:20:08 -04:00
2012-11-01 11:17:15 -04:00
2012-09-28 11:47:42 +02:00
2012-10-13 10:46:48 +01:00
2012-12-12 08:18:24 -08:00
2012-11-28 21:49:02 -05:00
2012-12-20 18:49:14 -05:00
2012-12-20 22:34:00 +00:00
2012-12-20 22:04:07 +00:00
2012-10-13 10:46:48 +01:00
2012-11-26 13:41:19 -06:00
2012-12-11 13:44:36 -05:00
2012-10-12 00:32:03 -04:00
2012-11-13 15:48:40 -05:00
2012-12-17 17:15:12 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-06 03:04:57 +09:00
2012-10-13 10:46:48 +01:00
2012-11-23 14:28:53 +01:00
2012-11-08 16:58:30 +01:00
2012-11-08 16:58:30 +01:00
2012-12-18 15:02:12 -08:00
2012-11-21 10:07:48 +01:00
2012-10-29 21:31:32 +01:00
2012-12-06 10:39:54 +01:00
2012-11-02 12:44:51 -07:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-12 16:49:10 +01:00
2012-12-12 21:41:55 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-16 15:18:08 -08:00
2012-12-18 15:02:15 -08:00
2012-12-16 15:18:08 -08:00
2012-11-19 22:21:03 +00:00
2012-10-06 13:14:36 +02:00
2012-10-13 10:46:48 +01:00
2012-10-05 22:23:54 +02:00
2012-10-05 22:23:51 +02:00
2012-11-28 11:36:32 +01:00
2012-11-23 12:23:40 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-09 14:20:23 +01:00
2012-12-06 14:02:51 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-14 18:49:50 -05:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-14 13:05:26 +10:30
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-04 13:08:10 -05:00
2013-01-10 10:57:01 -08:00
2012-10-13 10:46:48 +01:00
2012-11-10 00:40:24 -08:00
2013-01-11 14:54:54 -08:00
2012-10-09 16:22:40 +09:00
2012-10-09 16:22:39 +09:00
2012-09-25 12:14:56 +02:00
2012-12-09 00:20:28 -05:00
2012-11-21 15:09:26 -08:00
2013-01-04 16:11:45 -08:00
2012-10-13 10:46:48 +01:00
2012-11-19 14:32:13 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-09 00:20:28 -05:00
2012-12-13 14:20:19 -08:00
2012-11-01 12:11:31 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-25 13:29:52 -05:00
2012-11-13 14:08:23 -05:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-09-26 13:42:26 -07:00
2012-10-13 10:46:48 +01:00
2012-11-19 16:41:21 +01:00
2012-10-13 10:46:48 +01:00
2012-12-20 17:40:20 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-08 13:49:48 +10:30
2012-12-16 15:40:50 -08:00
2012-10-13 10:46:48 +01:00
2012-09-26 13:52:36 -07:00
2012-11-28 10:33:03 -08:00
2012-11-20 16:15:02 +10:00
2012-11-03 14:50:15 -04:00
2012-12-13 15:31:08 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-26 14:28:51 -08:00
2012-10-10 01:15:44 -04:00
2013-01-14 13:29:15 -05:00
2012-10-06 02:48:09 +09:00
2012-10-13 10:46:48 +01:00
2013-02-19 15:17:08 -05:00
2013-01-11 14:54:55 -08:00
2012-11-30 11:48:05 +01:00
2012-10-13 10:46:48 +01:00
2012-12-17 13:39:11 -08:00
2012-10-13 10:46:48 +01:00
2012-10-24 11:52:21 -07:00
2013-02-05 20:38:48 +11:00
2012-12-11 17:22:28 -08:00
2012-12-12 17:38:33 -08:00
2013-01-02 17:32:13 -08:00
2012-11-23 14:29:51 -05:00
2012-12-16 15:18:08 -08:00
2012-10-13 10:46:48 +01:00
2012-12-01 10:07:54 +00:00
2012-12-18 10:56:07 -08:00
2013-01-11 14:54:56 -08:00
2012-11-15 15:41:22 -08:00
2013-02-05 20:38:48 +11:00
2013-01-04 16:11:46 -08:00
2012-11-19 05:59:19 -08:00
2012-10-01 18:02:07 -07:00
2013-01-12 13:27:05 +10:30
2012-09-28 14:31:03 +09:30
2012-12-14 13:06:40 +10:30
2012-10-08 13:50:21 +10:30
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2013-01-04 16:11:45 -08:00
2012-10-13 10:46:48 +01:00
2012-12-25 18:45:06 -05:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2013-01-11 15:55:48 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-06 00:30:46 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-15 15:21:52 -05:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-11 17:22:27 -08:00
2012-12-12 17:38:34 -08:00
2012-11-20 04:18:14 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-23 22:01:15 +00:00
2012-12-11 17:30:16 +00:00
2012-10-17 15:53:02 -05:00
2012-10-10 22:41:05 -04:00
2012-12-19 16:15:17 +00:00
2012-12-18 09:58:09 -08:00
2012-10-08 13:50:18 +10:30
2012-11-30 08:41:50 -08:00
2012-11-20 10:04:29 -08:00
2012-10-13 10:46:48 +01:00
2012-12-11 17:22:27 -08:00
2012-11-26 11:33:18 -08:00
2012-12-26 14:57:34 -08:00
2012-12-11 17:22:22 -08:00
2012-10-11 08:50:14 +09:00
2012-12-11 17:22:26 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-26 10:43:06 -07:00
2012-12-13 12:14:47 -08:00
2012-12-17 17:15:18 -08:00
2012-10-06 03:04:44 +09:00
2012-10-24 10:01:59 +02:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-25 16:10:05 -08:00
2012-12-25 16:10:05 -08:00
2012-10-13 10:46:48 +01:00
2012-11-21 00:21:59 +01:00
2012-10-24 02:08:18 +02:00
2012-10-24 02:08:18 +02:00
2012-10-13 10:46:48 +01:00
2012-10-03 13:52:52 -07:00
2012-10-13 10:46:48 +01:00
2012-11-17 20:32:33 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-17 20:58:12 -08:00
2013-01-03 15:57:14 -08:00
2012-11-26 16:07:44 -08:00
2012-11-03 15:27:07 -04:00
2013-01-20 12:26:05 -08:00
2012-11-27 23:29:12 -02:00
2012-11-22 22:47:12 +01:00
2012-10-13 10:46:48 +01:00
2012-12-17 17:15:26 -08:00
2012-10-05 09:26:01 -07:00
2013-01-11 14:54:56 -08:00
2012-10-09 16:22:40 +09:00
2012-11-13 14:08:21 -08:00
2012-11-30 11:40:07 -08:00
2012-10-13 10:46:48 +01:00
2012-12-11 12:39:32 +09:00
2012-12-18 15:02:12 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-02 10:21:48 -04:00
2012-10-06 03:05:21 +09:00
2012-11-16 14:33:04 -08:00
2012-12-11 14:43:00 +00:00
2012-10-06 03:05:01 +09:00
2012-10-13 10:46:48 +01:00
2012-10-31 13:18:29 -04:00
2013-01-16 12:13:20 -08:00
2012-09-27 12:45:28 +02:00
2012-10-13 10:46:48 +01:00
2013-01-22 08:50:08 -08:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2013-01-14 18:16:59 -05:00
2012-10-13 10:46:48 +01:00
2012-11-16 04:39:15 -08:00
2012-11-04 11:25:56 +00:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-08 15:21:30 +09:00
2012-12-11 17:22:25 -08:00
2012-12-19 18:07:41 -05:00
2012-10-13 10:46:48 +01:00
2012-12-09 00:20:28 -05:00
2012-12-18 15:02:13 -08:00
2012-12-18 15:02:14 -08:00
2012-09-25 10:11:14 +03:00
2012-12-18 15:02:14 -08:00
2012-12-07 12:48:00 -05:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-27 15:38:29 -07:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-12-13 12:00:02 -08:00
2012-12-17 17:15:17 -08:00
2012-11-16 21:56:50 +01:00
2012-10-13 10:46:48 +01:00
2012-10-09 16:22:55 +09:00
2012-10-30 09:32:07 -04:00
2012-10-13 10:46:48 +01:00
2012-12-20 18:05:28 -08:00
2012-11-18 20:30:55 -05:00
2012-12-09 00:20:28 -05:00
2012-11-05 11:36:06 -07:00
2012-12-12 15:34:48 +08:00
2012-12-18 15:02:13 -08:00
2012-11-15 00:34:19 +01:00
2012-10-13 10:46:48 +01:00
2012-10-09 16:22:32 +09:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-13 15:48:27 -05:00
2012-10-22 16:58:28 -07:00
2012-11-15 17:20:58 -08:00
2012-12-11 17:22:27 -08:00
2012-12-09 00:20:28 -05:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-11-16 14:52:51 +01:00
2013-01-25 15:06:01 -08:00
2012-10-13 10:46:48 +01:00
2012-11-20 04:19:49 -08:00
2012-11-20 04:19:49 -08:00
2012-10-13 10:46:48 +01:00
2012-11-05 17:09:51 +00:00
2012-10-13 10:46:48 +01:00
2012-11-19 14:31:35 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-13 10:46:48 +01:00
2012-10-22 18:20:00 +10:30
2012-12-18 15:20:43 +10:30
2012-12-16 15:18:08 -08:00
2012-12-11 14:42:48 +00:00
2012-10-13 10:46:48 +01:00
2012-11-19 16:41:21 +01:00
2012-11-30 11:47:57 +01:00
2012-10-13 10:46:48 +01:00
2012-12-19 22:24:55 +01:00
2012-10-13 10:46:48 +01:00
2012-12-11 17:22:21 -08:00
2012-10-13 10:46:48 +01:00
f84adf4921