Sudeep Holla
4b68bb0be3
The return value ret.a2 is of type unsigned long and FFA_RET_NO_DATA is
a negative value.
Since the return value from the firmware can be just 32-bit even on
64-bit systems as FFA specification mentions it as int32 error code in
w0 register, explicitly casting to s32 ensures correct sign interpretation
when comparing against a signed error code FFA_RET_NO_DATA.
Without casting, comparison between unsigned long and a negative
constant could lead to unintended results due to type promotions.
Fixes: 3522be48d8 ("firmware: arm_ffa: Implement the NOTIFICATION_INFO_GET interface")
Reported-by: Andrei Homescu <ahomescu@google.com>
Message-Id: <20250221095633.506678-2-sudeep.holla@arm.com>
Change-Id: I11f218090699f0a19d8fed7b0568cd1004575687
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
(cherry picked from commit 3e282f41585c4dd49b688bd6395fd6f21a57c9f7)
Signed-off-by: Andrei Homescu <ahomescu@xwf.google.com>
Bug: 435501117