tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

net: bcmasp: fix potential memory leak in bcmasp_xmit()

Browse Source 
The bcmasp_xmit() returns NETDEV_TX_OK without freeing skb
in case of mapping fails, add dev_kfree_skb() to fix it.

Fixes: 490cb41200 ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Acked-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://patch.msgid.link/20241014145901.48940-1-wanghai38@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Wang Hai
2024-10-14 22:59:01 +08:00
committed by Jakub Kicinski
parent c401ed1c70
commit fed07d3eb8
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c
+1
View File
@@ -322,6 +322,7 @@ static netdev_tx_t bcmasp_xmit(struct sk_buff *skb, struct net_device *dev)
} }
/* Rewind so we do not have a hole */ /* Rewind so we do not have a hole */
spb_index = intf->tx_spb_index; spb_index = intf->tx_spb_index;
dev_kfree_skb(skb);
return NETDEV_TX_OK; return NETDEV_TX_OK;
} }