tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Input: sparcspkr - avoid unannotated fall-through

Browse Source 
commit 8b1d858cbd4e1800e9336404ba7892b5a721230d upstream.

Fix follow warnings with clang-21i (and reformat for clarity):
  drivers/input/misc/sparcspkr.c:78:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
     78 |                 case SND_TONE: break;
        |                 ^
  drivers/input/misc/sparcspkr.c:78:3: note: insert 'break;' to avoid fall-through
     78 |                 case SND_TONE: break;
        |                 ^
        |                 break;
  drivers/input/misc/sparcspkr.c:113:3: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
    113 |                 case SND_TONE: break;
        |                 ^
  drivers/input/misc/sparcspkr.c:113:3: note: insert 'break;' to avoid fall-through
    113 |                 case SND_TONE: break;
        |                 ^
        |                 break;
  2 warnings generated.

Signed-off-by: WangYuli <wangyuli@uniontech.com>
Link: https://lore.kernel.org/r/6730E40353C76908+20250415052439.155051-1-wangyuli@uniontech.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
WangYuli
2025-04-18 18:37:18 -07:00
committed by Greg Kroah-Hartman
parent 82b6dfff0d
commit f6ac7d68bb
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/input/misc/sparcspkr.c
+16 -6
View File
@@ -75,9 +75,14 @@ static int bbc_spkr_event(struct input_dev *dev, unsigned int type, unsigned int
return -1; return -1;
switch (code) { switch (code) {
case SND_BELL: if (value) value = 1000; case SND_BELL:
case SND_TONE: break; if (value)
default: return -1; value = 1000;
break;
case SND_TONE:
break;
default:
return -1;
} }
if (value > 20 && value < 32767) if (value > 20 && value < 32767)
@@ -113,9 +118,14 @@ static int grover_spkr_event(struct input_dev *dev, unsigned int type, unsigned
return -1; return -1;
switch (code) { switch (code) {
case SND_BELL: if (value) value = 1000; case SND_BELL:
case SND_TONE: break; if (value)
default: return -1; value = 1000;
break;
case SND_TONE:
break;
default:
return -1;
} }
if (value > 20 && value < 32767) if (value > 20 && value < 32767)