tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

powerpc/vio: Use put_device() on device_register failure

Browse Source 
The kernel doc for device_register (and device_initialize) very clearly
state to call put_device not kfree after calling, even on error.

Signed-off-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
This commit is contained in:
Nishanth Aravamudan
2010-09-15 08:05:47 +00:00
committed by Benjamin Herrenschmidt
parent ffa56e555a
commit edea8f6f48
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
arch/powerpc/kernel/vio.c
+1 -2
View File
@@ -1254,8 +1254,7 @@ struct vio_dev *vio_register_device_node(struct device_node *of_node)
if (device_register(&viodev->dev)) { if (device_register(&viodev->dev)) {
printk(KERN_ERR "%s: failed to register device %s\n", printk(KERN_ERR "%s: failed to register device %s\n",
__func__, dev_name(&viodev->dev)); __func__, dev_name(&viodev->dev));
/* XXX free TCE table */ put_device(&viodev->dev);
kfree(viodev);
return NULL; return NULL;
} }