scsi: target: core: Change ASCQ for residual write

According to FCP-4 (9.4.2):

  If the command requested that data beyond the length specified by the
  FCP_DL field be transferred, then the device server shall set the
  FCP_RESID_OVER bit (see 9.5.8) to one in the FCP_RSP IU and:

  a) process the command normally except that data beyond the FCP_DL count
  shall not be requested or transferred;

  b) transfer no data and return CHECK CONDITION status with the sense key
  set to ILLEGAL REQUEST and the additional sense code set to INVALID FIELD
  IN COMMAND INFORMATION UNIT; or

  c) may transfer data and return CHECK CONDITION status with the sense key
  set to ABORTED COMMAND and the additional sense code set to INVALID FIELD
  IN COMMAND INFORMATION UNIT.

TCM follows b) and transfers no data for residual writes but returns
INVALID FIELD IN CDB instead of INVALID FIELD IN COMMAND INFORMATION UNIT.

Change the ASCQ to INVALID FIELD IN COMMAND INFORMATION UNIT to meet the
standard.

Link: https://lore.kernel.org/r/20201203082035.54566-4-a.kovaleva@yadro.com
Signed-off-by: Anastasia Kovaleva <a.kovaleva@yadro.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

This commit is contained in:

Anastasia Kovaleva

2020-12-03 11:20:35 +03:00

committed by

Martin K. Petersen

parent cc0b6ad72e

commit ead0ffc95a

2 changed files with 8 additions and 1 deletions

									
										include/target/target_core_base.h
									
		+1
		
												View File
												
				@@ -187,6 +187,7 @@ enum tcm_sense_reason_table {

					TCM_UNSUPPORTED_SEGMENT_DESC_TYPE_CODE	= R(0x1c),

					TCM_INSUFFICIENT_REGISTRATION_RESOURCES	= R(0x1d),

					TCM_LUN_BUSY				= R(0x1e),

					TCM_INVALID_FIELD_IN_COMMAND_IU         = R(0x1f),

				#undef R

				};