From c107697c82af8b9a0f1f914fa961cdb87a1a825f Mon Sep 17 00:00:00 2001 From: Marco Pagani Date: Tue, 4 Jun 2024 12:25:35 +0200 Subject: [PATCH 1/2] Revert "fpga: disable KUnit test suites when module support is enabled" This reverts commit a3fad2e92c76587fe262a1a4a122045b29885354. The core components of the subsystem no longer assume that low-level modules register a driver for the parent device and rely on its owner pointer to take the module's refcount. KUnit test suites can now be safely re-enabled with loadable module support. Signed-off-by: Marco Pagani Acked-by: Xu Yilun Link: https://lore.kernel.org/r/20240604102536.59010-1-marpagan@redhat.com Signed-off-by: Xu Yilun --- drivers/fpga/tests/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/fpga/tests/Kconfig b/drivers/fpga/tests/Kconfig index d4e55204c092..e4a64815f16d 100644 --- a/drivers/fpga/tests/Kconfig +++ b/drivers/fpga/tests/Kconfig @@ -1,6 +1,6 @@ config FPGA_KUNIT_TESTS - bool "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS - depends on FPGA=y && FPGA_REGION=y && FPGA_BRIDGE=y && KUNIT=y && MODULES=n + tristate "KUnit test for the FPGA subsystem" if !KUNIT_ALL_TESTS + depends on FPGA && FPGA_REGION && FPGA_BRIDGE && KUNIT=y default KUNIT_ALL_TESTS help This builds unit tests for the FPGA subsystem From 3a0fa8e97d3024de199634667900b6a90bbe43d0 Mon Sep 17 00:00:00 2001 From: "Dr. David Alan Gilbert" Date: Thu, 30 May 2024 21:52:45 +0100 Subject: [PATCH 2/2] fpga: altera-fpga2sdram: remove unused struct 'prop_map' 'prop_map' has been unused since the original commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support"). Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Russ Weight Acked-by: Xu Yilun Link: https://lore.kernel.org/r/20240530205245.125513-1-linux@treblig.org Signed-off-by: Xu Yilun --- drivers/fpga/altera-fpga2sdram.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c index 6b60ca004345..f4de3fea0b2d 100644 --- a/drivers/fpga/altera-fpga2sdram.c +++ b/drivers/fpga/altera-fpga2sdram.c @@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable) return _alt_fpga2sdram_enable_set(bridge->priv, enable); } -struct prop_map { - char *prop_name; - u32 *prop_value; - u32 prop_max; -}; - static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = { .enable_set = alt_fpga2sdram_enable_set, .enable_show = alt_fpga2sdram_enable_show,