tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

crypto: caam - Kill SPRINTFCAT() with fire

Browse Source 
This macro is just like an encyclopedia of string handling done wrong.
This must die. This is so wrong on so many levels.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Horia Geanta <horia.geanta@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Marek Vasut
2014-04-24 20:05:20 +02:00
committed by Herbert Xu
parent 4f0fa52a5d
commit e22cdcfa13
1 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/crypto/caam/error.c
-10
View File
@@ -158,16 +158,6 @@ static const char * const rng_err_id_list[] = {
"Secure key generation", "Secure key generation",
}; };
#define SPRINTFCAT(str, format, param, max_alloc) \
{ \
char *tmp; \
\
tmp = kmalloc(sizeof(format) + max_alloc, GFP_ATOMIC); \
sprintf(tmp, format, param); \
strcat(str, tmp); \
kfree(tmp); \
}
static void report_ccb_status(struct device *jrdev, u32 status, static void report_ccb_status(struct device *jrdev, u32 status,
const char *error, char *__outstr) const char *error, char *__outstr)
{ {