tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

scsi: ufs: exynos: Move phy calls to .exit() callback

Browse Source 
[ Upstream commit 67e4085015c33bf2fb552af1f171c58b81ef0616 ]

ufshcd_pltfrm_remove() calls ufshcd_remove(hba) which in turn calls
ufshcd_hba_exit().

By moving the phy_power_off() and phy_exit() calls to the newly created
.exit callback they get called by ufshcd_variant_hba_exit() before
ufshcd_hba_exit() turns off the regulators. This is also similar flow to
the ufs-qcom driver.

Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20250319-exynos-ufs-stability-fixes-v2-6-96722cc2ba1b@linaro.org
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Peter Griffin
2025-03-19 15:30:23 +00:00
committed by Greg Kroah-Hartman
parent c0724ac138
commit b7a05edb28
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/ufs/host/ufs-exynos.c
+9 -6
View File
@@ -1490,6 +1490,14 @@ out:
return ret; return ret;
} }
static void exynos_ufs_exit(struct ufs_hba *hba)
{
struct exynos_ufs *ufs = ufshcd_get_variant(hba);
phy_power_off(ufs->phy);
phy_exit(ufs->phy);
}
static int exynos_ufs_host_reset(struct ufs_hba *hba) static int exynos_ufs_host_reset(struct ufs_hba *hba)
{ {
struct exynos_ufs *ufs = ufshcd_get_variant(hba); struct exynos_ufs *ufs = ufshcd_get_variant(hba);
@@ -1958,6 +1966,7 @@ static int gs101_ufs_pre_pwr_change(struct exynos_ufs *ufs,
static const struct ufs_hba_variant_ops ufs_hba_exynos_ops = { static const struct ufs_hba_variant_ops ufs_hba_exynos_ops = {
.name = "exynos_ufs", .name = "exynos_ufs",
.init = exynos_ufs_init, .init = exynos_ufs_init,
.exit = exynos_ufs_exit,
.hce_enable_notify = exynos_ufs_hce_enable_notify, .hce_enable_notify = exynos_ufs_hce_enable_notify,
.link_startup_notify = exynos_ufs_link_startup_notify, .link_startup_notify = exynos_ufs_link_startup_notify,
.pwr_change_notify = exynos_ufs_pwr_change_notify, .pwr_change_notify = exynos_ufs_pwr_change_notify,
@@ -1996,13 +2005,7 @@ static int exynos_ufs_probe(struct platform_device *pdev)
static void exynos_ufs_remove(struct platform_device *pdev) static void exynos_ufs_remove(struct platform_device *pdev)
{ {
struct ufs_hba *hba = platform_get_drvdata(pdev);
struct exynos_ufs *ufs = ufshcd_get_variant(hba);
ufshcd_pltfrm_remove(pdev); ufshcd_pltfrm_remove(pdev);
phy_power_off(ufs->phy);
phy_exit(ufs->phy);
} }
static struct exynos_ufs_uic_attr exynos7_uic_attr = { static struct exynos_ufs_uic_attr exynos7_uic_attr = {