tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: rtl8723bs: hal: Remove NULL check before kfree

Browse Source 
NULL check before kfree is unnecessary so remove it.

The following Coccinelle script was used to detect this:
@@ expression E; @@
- if (E != NULL) { kfree(E); }
+ kfree(E);
@@ expression E; @@
- if (E != NULL) { kfree(E); E = NULL; }
+ kfree(E);
+ E = NULL;

Signed-off-by: Simran Singhal <singhalsimran0@gmail.com>
Link: https://lore.kernel.org/r/20200326132823.GA18625@simran-Inspiron-5558
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Simran Singhal
2020-03-26 18:58:23 +05:30
committed by Greg Kroah-Hartman
parent 1879d30ede
commit b67b7b0465
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c
+4 -8
View File
@@ -480,10 +480,8 @@ initbuferror:
precvpriv->precv_buf = NULL;
}
if (precvpriv->pallocated_recv_buf) {
kfree(precvpriv->pallocated_recv_buf);
precvpriv->pallocated_recv_buf = NULL;
}
kfree(precvpriv->pallocated_recv_buf);
precvpriv->pallocated_recv_buf = NULL;
exit:
return res;
@@ -518,8 +516,6 @@ void rtl8723bs_free_recv_priv(struct adapter *padapter)
precvpriv->precv_buf = NULL;
}
if (precvpriv->pallocated_recv_buf) {
kfree(precvpriv->pallocated_recv_buf);
precvpriv->pallocated_recv_buf = NULL;
}
kfree(precvpriv->pallocated_recv_buf);
precvpriv->pallocated_recv_buf = NULL;
}