tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: comedi: refactor fl512 driver to remove forward declarations

Browse Source 
Move the module_init/module_exit routines and the associated
struct comedi_driver and other variables to the end of the source.
This is more typical of how other drivers are written and removes
the need for the forward declarations.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten
2012-04-27 17:31:27 -07:00
committed by Greg Kroah-Hartman
parent 236788fcf0
commit a39eb9061b
1 changed files with 19 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/staging/comedi/drivers/fl512.c
+19 -35
View File
@@ -42,38 +42,6 @@ static const struct comedi_lrange range_fl512 = { 4, {
}
};
static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it);
static int fl512_detach(struct comedi_device *dev);
static struct comedi_driver driver_fl512 = {
.driver_name = "fl512",
.module = THIS_MODULE,
.attach = fl512_attach,
.detach = fl512_detach,
};
static int __init driver_fl512_init_module(void)
{
return comedi_driver_register(&driver_fl512);
}
static void __exit driver_fl512_cleanup_module(void)
{
comedi_driver_unregister(&driver_fl512);
}
module_init(driver_fl512_init_module);
module_exit(driver_fl512_cleanup_module);
static int fl512_ai_insn(struct comedi_device *dev,
struct comedi_subdevice *s, struct comedi_insn *insn,
unsigned int *data);
static int fl512_ao_insn(struct comedi_device *dev, struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data);
static int fl512_ao_insn_readback(struct comedi_device *dev,
struct comedi_subdevice *s,
struct comedi_insn *insn, unsigned int *data);
/*
* fl512_ai_insn : this is the analog input function
*/
@@ -140,9 +108,6 @@ static int fl512_ao_insn_readback(struct comedi_device *dev,
return n;
}
/*
* start attach
*/
static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it)
{
unsigned long iobase;
@@ -217,6 +182,25 @@ static int fl512_detach(struct comedi_device *dev)
return 0;
}
static struct comedi_driver driver_fl512 = {
.driver_name = "fl512",
.module = THIS_MODULE,
.attach = fl512_attach,
.detach = fl512_detach,
};
static int __init driver_fl512_init_module(void)
{
return comedi_driver_register(&driver_fl512);
}
module_init(driver_fl512_init_module);
static void __exit driver_fl512_cleanup_module(void)
{
comedi_driver_unregister(&driver_fl512);
}
module_exit(driver_fl512_cleanup_module);
MODULE_AUTHOR("Comedi http://www.comedi.org");
MODULE_DESCRIPTION("Comedi low-level driver");
MODULE_LICENSE("GPL");