net: more accurate skb truesize
skb truesize currently accounts for sk_buff struct and part of skb head. kmalloc() roundings are also ignored. Considering that skb_shared_info is larger than sk_buff, its time to take it into account for better memory accounting. This patch introduces SKB_TRUESIZE(X) macro to centralize various assumptions into a single place. At skb alloc phase, we put skb_shared_info struct at the exact end of skb head, to allow a better use of memory (lowering number of reallocations), since kmalloc() gives us power-of-two memory blocks. Unless SLUB/SLUB debug is active, both skb->head and skb_shared_info are aligned to cache lines, as before. Note: This patch might trigger performance regressions because of misconfigured protocol stacks, hitting per socket or global memory limits that were previously not reached. But its a necessary step for a more accurate memory accounting. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> CC: Andi Kleen <ak@linux.intel.com> CC: Ben Hutchings <bhutchings@solarflare.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
committed by
David S. Miller
parent
97ba0eb64c
commit
87fb4b7b53
@@ -46,6 +46,11 @@
|
||||
#define SKB_MAX_HEAD(X) (SKB_MAX_ORDER((X), 0))
|
||||
#define SKB_MAX_ALLOC (SKB_MAX_ORDER(0, 2))
|
||||
|
||||
/* return minimum truesize of one skb containing X bytes of data */
|
||||
#define SKB_TRUESIZE(X) ((X) + \
|
||||
SKB_DATA_ALIGN(sizeof(struct sk_buff)) + \
|
||||
SKB_DATA_ALIGN(sizeof(struct skb_shared_info)))
|
||||
|
||||
/* A. Checksumming of received packets by device.
|
||||
*
|
||||
* NONE: device failed to checksum this packet.
|
||||
|
||||
Reference in New Issue
Block a user