drm/gem: Fix mmap fake offset handling for drm_gem_object_funcs.mmap
Commitc40069cb7b("drm: add mmap() to drm_gem_object_funcs") introduced a GEM object mmap() hook which is expected to subtract the fake offset from vm_pgoff. However, for mmap() on dmabufs, there is not a fake offset. To fix this, let's always call mmap() object callback with an offset of 0, and leave it up to drm_gem_mmap_obj() to remove the fake offset. TTM still needs the fake offset, so we have to add it back until that's fixed. Fixes:c40069cb7b("drm: add mmap() to drm_gem_object_funcs") Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Rob Herring <robh@kernel.org> Acked-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20191024191859.31700-1-robh@kernel.org
This commit is contained in:
@@ -159,8 +159,9 @@ struct drm_gem_object_funcs {
|
||||
*
|
||||
* The callback is used by by both drm_gem_mmap_obj() and
|
||||
* drm_gem_prime_mmap(). When @mmap is present @vm_ops is not
|
||||
* used, the @mmap callback must set vma->vm_ops instead.
|
||||
*
|
||||
* used, the @mmap callback must set vma->vm_ops instead. The @mmap
|
||||
* callback is always called with a 0 offset. The caller will remove
|
||||
* the fake offset as necessary.
|
||||
*/
|
||||
int (*mmap)(struct drm_gem_object *obj, struct vm_area_struct *vma);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user