tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

FROMGIT: drm: writeback: Fix use after free in drm_writeback_connector_cleanup()

Browse Source 
The drm_writeback_cleanup_job() function frees "pos" so call
list_del(&pos->list_entry) first to avoid a use after free.

Fixes: 1914ba2b91ea ("drm: writeback: Create drmm variants for drm_writeback_connector initialization")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/78abd541-71e9-4b3b-a05d-2c7caf8d5b2f@stanley.mountain
Signed-off-by: Maxime Ripard <mripard@kernel.org>
(cherry picked from commit ff3881cc6a588f8cd714c9ffbbcc9ef6b02c8d0f
 https://anongit.freedesktop.org/git/drm/drm-misc.git drm-misc-next)

Fixes: 8d550a8ffc ("FROMGIT: drm: writeback: Create drmm variants for
drm_writeback_connector initialization")

Bug: 414366730
Test: atest VtsHalGraphicsComposer3_TargetTest

Change-Id: I889a42e9651a41e7f98f4f9daa00796b896bdc8d
Signed-off-by: Paz Zcharya <pazz@google.com>
This commit is contained in:
Dan Carpenter
2025-02-12 18:23:48 +03:00
committed by Paz Zcharya
parent 3405224680
commit 64307f8895
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/gpu/drm/drm_writeback.c
View File

@@ -366,8 +366,8 @@ static void drm_writeback_connector_cleanup(struct drm_device *dev,
spin_lock_irqsave(&wb_connector->job_lock, flags);
list_for_each_entry_safe(pos, n, &wb_connector->job_queue, list_entry) {
drm_writeback_cleanup_job(pos);
list_del(&pos->list_entry);
drm_writeback_cleanup_job(pos);
}
spin_unlock_irqrestore(&wb_connector->job_lock, flags);
}