tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

staging: comedi: amplc_dio200: use comedi_legacy_detach()

Browse Source 
The I/O region used by this driver is always requested using
comedi_request_region(). The devpriv->io union is only used by
the common code shared by the legacy and PCI drivers.

Use the new comedi_legacy_detach() helper in the (*detach) to
release the I/O region requested by this driver. That function
will handle the proper sanity checking before releasing the
resource.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten
2013-04-18 14:33:40 -07:00
committed by Greg Kroah-Hartman
parent 21208519d4
commit 60cb3b02bc
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/staging/comedi/drivers/amplc_dio200.c
+1 -7
View File
@@ -292,14 +292,8 @@ static int dio200_attach(struct comedi_device *dev, struct comedi_devconfig *it)
static void dio200_detach(struct comedi_device *dev) static void dio200_detach(struct comedi_device *dev)
{ {
const struct dio200_board *thisboard = comedi_board(dev);
struct dio200_private *devpriv = dev->private;
if (!thisboard || !devpriv)
return;
amplc_dio200_common_detach(dev); amplc_dio200_common_detach(dev);
if (devpriv->io.regtype == io_regtype) comedi_legacy_detach(dev);
release_region(devpriv->io.u.iobase, thisboard->mainsize);
} }
static struct comedi_driver amplc_dio200_driver = { static struct comedi_driver amplc_dio200_driver = {