From 50c134f2a9eac39373d937785d18e4386f48532b Mon Sep 17 00:00:00 2001 From: Filipe Manana Date: Fri, 5 Jun 2026 17:25:50 +0100 Subject: [PATCH] btrfs: move WARN_ON on unexpected error in __add_tree_block() There's no point in having the WARN_ON(1) inside the if statement for the unexpected error. Move it into the if statement's condition, which brings a couple benefits: 1) It marks the branch as unlikely, hinting the compiler to generate better code; 2) The WARN_ON() produces a stack trace after the dumped leaf and error message which can hide that more important information in case we get a truncated dmesg/syslog. Reviewed-by: Qu Wenruo Signed-off-by: Filipe Manana Signed-off-by: David Sterba --- fs/btrfs/relocation.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index e7771c4c4f38..5f1200e69692 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -3200,13 +3200,12 @@ again: goto again; } } - if (ret) { + if (WARN_ON(ret)) { ASSERT(ret == 1); btrfs_print_leaf(path->nodes[0]); btrfs_err(fs_info, "tree block extent item (%llu) is not found in extent tree", bytenr); - WARN_ON(1); return -EINVAL; }