From 32c1bffe815c9ed746ce7d84cae07da17db6bca4 Mon Sep 17 00:00:00 2001 From: HONG Yifan Date: Wed, 25 Sep 2024 11:39:01 -0700 Subject: [PATCH] ANDROID: Compile kselftest_timers_posix_timers code This partially reverts commit f3a29e7eb6dea8119f0d5132e39b52adf4d1ea76. Reason of revert: pthread_cancel symbol is added, so test can compile. However the tests still fail for two reasons: 1. pthread_cancel needs to be substituted with a functional equivalent in Android. 2. they depend on future patches: "(the tests) fail for now until the signal and posix timer code is updated." Bug: 369330443 Bug: 369693249 Change-Id: Icbb34b4726c2bb9d782cad27478a0c63e3785f96 Signed-off-by: HONG Yifan Signed-off-by: Edward Liaw --- tools/testing/selftests/timers/posix_timers.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c index 603afa6471c6..33848b36980f 100644 --- a/tools/testing/selftests/timers/posix_timers.c +++ b/tools/testing/selftests/timers/posix_timers.c @@ -254,8 +254,6 @@ static void *ignore_thread(void *arg) return NULL; } -// TODO: b/369330443 - broken due to missing pthread_cancel in sysroot -#if 0 static void check_sig_ign(int thread) { struct tmrsig tsig = { }; @@ -341,7 +339,6 @@ static void check_sig_ign(int thread) "check_sig_ign SIGEV_THREAD_ID\n"); } } -#endif static void check_rearm(void) { @@ -628,7 +625,7 @@ int main(int argc, char **argv) check_timer_create(CLOCK_PROCESS_CPUTIME_ID, "CLOCK_PROCESS_CPUTIME_ID"); check_timer_distribution(); -// TODO: b/369330443 - broken due to missing pthread_cancel in sysroot +// TODO: b/369693249 - depends on future patches and pthread_cancel replacement #if 0 check_sig_ign(0); check_sig_ign(1);