exec: kill bprm->tcomm[], simplify the "basename" logic

Starting from commit c4ad8f98be ("execve: use 'struct filename *' for
executable name passing") bprm->filename can not go away after
flush_old_exec(), so we do not need to save the binary name in
bprm->tcomm[] added by 96e02d1586 ("exec: fix use-after-free bug in
setup_new_exec()").

And there was never need for filename_to_taskname-like code, we can
simply do set_task_comm(kbasename(filename).

This patch has to change set_task_comm() and trace_task_rename() to
accept "const char *", but I think this change is also good.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

This commit is contained in:

Oleg Nesterov

2014-04-07 15:38:39 -07:00

committed by

Linus Torvalds

parent 32ed74a4b9

commit 23aebe1691

4 changed files with 4 additions and 22 deletions

									
										include/trace/events/task.h
									
		+1
		-1
	
												View File
												
				@@ -32,7 +32,7 @@ TRACE_EVENT(task_newtask,

				TRACE_EVENT(task_rename,

					TP_PROTO(struct task_struct *task, char *comm),

					TP_PROTO(struct task_struct *task, const char *comm),

					TP_ARGS(task, comm),