tmakin/ack-tegra
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

wifi: rtw89: fw: propagate error code from rtw89_h2c_tx()

Browse Source 
[ Upstream commit 56e1acaa0f80620b8e2c3410db35b4b975782b0a ]

The error code should be propagated to callers during downloading firmware
header and body. Remove unnecessary assignment of -1.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250217064308.43559-4-pkshih@realtek.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Ping-Ke Shih
2025-02-17 14:43:06 +08:00
committed by Greg Kroah-Hartman
parent a4523765fa
commit 1cbef396c5
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/net/wireless/realtek/rtw89/fw.c
-2
View File
@@ -1234,7 +1234,6 @@ static int __rtw89_fw_download_hdr(struct rtw89_dev *rtwdev,
ret = rtw89_h2c_tx(rtwdev, skb, false); ret = rtw89_h2c_tx(rtwdev, skb, false);
if (ret) { if (ret) {
rtw89_err(rtwdev, "failed to send h2c\n"); rtw89_err(rtwdev, "failed to send h2c\n");
ret = -1;
goto fail; goto fail;
} }
@@ -1311,7 +1310,6 @@ static int __rtw89_fw_download_main(struct rtw89_dev *rtwdev,
ret = rtw89_h2c_tx(rtwdev, skb, true); ret = rtw89_h2c_tx(rtwdev, skb, true);
if (ret) { if (ret) {
rtw89_err(rtwdev, "failed to send h2c\n"); rtw89_err(rtwdev, "failed to send h2c\n");
ret = -1;
goto fail; goto fail;
} }