From 0b5aee52ee031640b7194c3a35ce6ba10f188e21 Mon Sep 17 00:00:00 2001 From: Tiffany Yang Date: Thu, 14 Aug 2025 14:26:19 -0700 Subject: [PATCH] ANDROID: Fix uninitialized 'done' in scmi_cpufreq MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix the following KernelCI build error when compiling with gcc: drivers/cpufreq/scmi-cpufreq.c: In function ‘scmi_limit_notify_cb’: drivers/cpufreq/scmi-cpufreq.c:198:13: error: ‘done’ is used uninitialized [-Werror=uninitialized] 198 | if (done) | ^~~~ drivers/cpufreq/scmi-cpufreq.c:193:14: note: ‘done’ was declared here 193 | bool done; | ^~~~ cc1: all warnings being treated as errors make[4]: *** [scripts/Makefile.build:240: drivers/cpufreq/scmi-cpufreq.o] Error 1 Fixes: a475a3d8e54f ("ANDROID: scmi_cpufreq: Add restricted vendor hook for scmi_limit_notify_cb") Change-Id: I12b4651aaa2f95e120fd8ce6dcddfd36d6d6373d Signed-off-by: Tiffany Yang --- drivers/cpufreq/scmi-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index e5a9d68088b2..ffcdf80712e5 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -189,8 +189,8 @@ static int scmi_limit_notify_cb(struct notifier_block *nb, unsigned long event, struct scmi_data *priv = container_of(nb, struct scmi_data, limit_notify_nb); struct scmi_perf_limits_report *limit_notify = data; unsigned int limit_freq_khz; + bool done = false; int ret = 0; - bool done; limit_freq_khz = limit_notify->range_max_freq / HZ_PER_KHZ;